Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader #3837

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Oct 24, 2018

Changelog: Fix: Internal improvements of the ConanFile loader

Instead of load the conanfile using the file path as the module name, use directly the uuid.
Warning: This change makes sense for me but I feel like it could be other reasons for the previous code.

Partially does #3631

@lasote lasote added this to the 1.9 milestone Oct 24, 2018

@lasote lasote requested a review from memsharded Oct 24, 2018

@ghost ghost assigned lasote Oct 24, 2018

@ghost ghost added the stage: review label Oct 24, 2018

@lasote lasote requested a review from danimtb Oct 24, 2018

@memsharded memsharded merged commit 2686c97 into conan-io:develop Oct 24, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 24, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.