Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow wildcards in 'conan download' command #3843

Merged
merged 3 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Oct 24, 2018

Changelog: Fix: do not allow wildcards in command conan download <ref-without-wildcards>

@jgsogo jgsogo added this to the 1.9 milestone Oct 24, 2018

@jgsogo jgsogo requested a review from memsharded Oct 24, 2018

@ghost ghost assigned jgsogo Oct 24, 2018

@ghost ghost added the stage: review label Oct 24, 2018

@memsharded
Copy link
Contributor

left a comment

good! See the comment, change if you feel to, or leave it as-is, both good, and merge.

@@ -5,6 +5,16 @@
from conans.model.version import Version


def check_valid_ref(ref, allow_pattern=False):

This comment has been minimized.

Copy link
@memsharded

memsharded Oct 24, 2018

Contributor

allow_pattern is always False, then so far it is a bit speculative, isn't it?

This comment has been minimized.

Copy link
@jgsogo

jgsogo Oct 24, 2018

Author Member

Maybe it is better not to provide a default, I'll change it.

@danimtb danimtb merged commit b621944 into conan-io:develop Oct 24, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 24, 2018

@jgsogo jgsogo deleted the jgsogo:issue/3699-download-pattern branch Oct 25, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Do not allow wildcards in 'conan download' command (conan-io#3843)
* do not allow wildcards in download

* remove default variable value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.