Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow wildcards in 'conan download' command #3843

Merged
merged 3 commits into from Oct 24, 2018

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Oct 24, 2018

Changelog: Fix: do not allow wildcards in command conan download <ref-without-wildcards>

@jgsogo jgsogo added this to the 1.9 milestone Oct 24, 2018
@jgsogo jgsogo requested a review from memsharded Oct 24, 2018
@ghost ghost assigned jgsogo Oct 24, 2018
@ghost ghost added the stage: review label Oct 24, 2018
Copy link
Member

@memsharded memsharded left a comment

good! See the comment, change if you feel to, or leave it as-is, both good, and merge.

@@ -5,6 +5,16 @@
from conans.model.version import Version


def check_valid_ref(ref, allow_pattern=False):
Copy link
Member

@memsharded memsharded Oct 24, 2018

allow_pattern is always False, then so far it is a bit speculative, isn't it?

Copy link
Member Author

@jgsogo jgsogo Oct 24, 2018

Maybe it is better not to provide a default, I'll change it.

@danimtb danimtb merged commit b621944 into conan-io:develop Oct 24, 2018
1 of 2 checks passed
@ghost ghost removed the stage: review label Oct 24, 2018
@jgsogo jgsogo deleted the issue/3699-download-pattern branch Oct 25, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
* do not allow wildcards in download

* remove default variable value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants