Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Plugins as Hooks #3867

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Oct 29, 2018

Changelog: Fix: Renamed Plugins as Hooks

  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ghost ghost assigned danimtb Oct 29, 2018

@ghost ghost added the stage: review label Oct 29, 2018

@danimtb danimtb referenced this pull request Oct 29, 2018

Merged

Renamed Plugins to Hooks #919

@danimtb danimtb added this to the 1.9 milestone Oct 29, 2018

@danimtb danimtb assigned jgsogo and unassigned danimtb Oct 29, 2018

@jgsogo

jgsogo approved these changes Oct 29, 2018

Copy link
Member

left a comment

LGTM. Waiting for the related change in docs.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Oct 29, 2018

Just seen them, it was already merged 🤦‍♂️

@jgsogo jgsogo merged commit 2339378 into conan-io:develop Oct 29, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 29, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Rename Plugins as Hooks (conan-io#3867)
* Rename Plugins as Hooks

* Migration from plugins to hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.