Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdir fails when the directory exists #4012

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Nov 27, 2018

Changelog: Bugfix: A conan install with a reference failed when running in the operating system root folder because python tried to create the directory even when nothing is going to be written.

Closes #4002

The real issue happen if you try to run os.makedirs("c:") python will fail with a different error than EEXIST, note that the directory c:\ of course, exists, and we are able to write it even! But we cannot create it.

@lasote lasote added this to the 1.10 milestone Nov 27, 2018

@lasote lasote requested a review from memsharded Nov 27, 2018

@ghost ghost assigned lasote Nov 27, 2018

@ghost ghost added the stage: review label Nov 27, 2018

@jgsogo

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

It makes sense. Although I'm afraid that given mkdir("C:"), Conan will call rmdir("C:") at some point ☠️ , but yes, this is a licit usage.

@jgsogo jgsogo merged commit afe1469 into conan-io:develop Nov 27, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Nov 27, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

mkdir fails when the directory exists (conan-io#4012)
* mkdir fails when the directory exists

* Simplified code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.