Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum deploy better check for Artifactory #4100

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@lasote
Copy link
Contributor

commented Dec 10, 2018

Changelog: Fix: Fixed the check of the return code from Artifactory when using the checksum deploy feature.
Docs: omit

status_code != 404 could be even a 500 error. Checked with Artifactory team that the code to check is a "201" when the file exists or it has been created.

@lasote lasote added this to the 1.11 milestone Dec 10, 2018

@lasote lasote requested a review from memsharded Dec 10, 2018

@ghost ghost assigned lasote Dec 10, 2018

@ghost ghost added the stage: review label Dec 10, 2018

@lasote lasote changed the title Better to check the return code of the file indeed there than otherwise Checksum deploy better check for Artifactory Dec 10, 2018

@lasote lasote merged commit 0744a08 into conan-io:develop Dec 11, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 11, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.