Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of hooks folders and naming #4106

Merged
merged 23 commits into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Dec 11, 2018

MERGE THIS PR AFTER #4083

Changelog: Feature: Allow hooks to be stored in folders
Docs: conan-io/docs#979

  • Refer to the issue that supports this Pull Request: closes #3593
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one

@ghost ghost assigned danimtb Dec 11, 2018

@ghost ghost added the stage: review label Dec 11, 2018

@danimtb danimtb referenced this pull request Dec 11, 2018

Closed

How to install a plugin #872

@lasote

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

This is very broken, take a look

@jgsogo jgsogo referenced this pull request Dec 12, 2018

Closed

[hooks] Attribute checker for alias #4078

3 of 3 tasks complete

@danimtb danimtb added this to the 1.11 milestone Dec 13, 2018

@lasote

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

Conflicted and broken, fix asap, otherwise it will be out of the release


======================================================================

FAIL: test_git_checkout_is_possible (blocked_v2.conans.test.command.config_install_test.ConfigInstallTest)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/tmp/source/b14a/py27/blocked_v2/conans/test/command/config_install_test.py", line 391, in test_git_checkout_is_possible

    self.assertTrue(os.path.exists(file_path))

AssertionError: False is not true

danimtb added some commits Dec 17, 2018

@lasote lasote requested a review from memsharded Dec 18, 2018

@lasote lasote assigned lasote and unassigned danimtb Dec 18, 2018

@ghost ghost assigned danimtb Dec 18, 2018

@danimtb danimtb removed their assignment Dec 18, 2018

@ghost ghost assigned danimtb Dec 18, 2018

@lasote

lasote approved these changes Dec 18, 2018

@memsharded memsharded merged commit 4c5801a into conan-io:develop Dec 18, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 18, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#4106 from danimtb/feature/3593
Management of hooks folders and naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.