Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add lib targets to generated targets of cmake_find_package #4125

Conversation

@Manu343726
Copy link
Contributor

@Manu343726 Manu343726 commented Dec 13, 2018

Changelog: Fix: cmake_find_package generator not forwarding all dependency properties
Docs: omit
closes #4124

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.
@memsharded
Copy link
Member

@memsharded memsharded commented Dec 13, 2018

I think it makes sense, but I am assigning it to @lasote for final check.

@danimtb
Copy link
Member

@danimtb danimtb commented Dec 17, 2018

Please check the conflicts. There has been a huge refactor of the tests layout

@lasote lasote added this to the 1.11 milestone Dec 18, 2018
@lasote lasote merged commit d1767f5 into conan-io:develop Dec 18, 2018
2 checks passed
@ghost ghost removed the stage: review label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants