Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/visjs #4133

Merged
merged 7 commits into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Dec 14, 2018

Changelog: Feature: Allow --graph=file.html html output using local vis.min.js and vis.min.css resources if they are found in the local cache (can be deployed via conan config install)

Close #3667

Docs: conan-io/docs#972

@ghost ghost assigned memsharded Dec 14, 2018

@ghost ghost added the stage: review label Dec 14, 2018

@memsharded memsharded assigned danimtb and unassigned memsharded Dec 14, 2018

@memsharded memsharded added this to the 1.11 milestone Dec 14, 2018

@danimtb
Copy link
Member

left a comment

Looking good, just look at the coupe of comments below

Show resolved Hide resolved conans/client/graph/grapher.py
Show resolved Hide resolved conans/test/command/info_test.py Outdated

@ghost ghost assigned memsharded Dec 14, 2018

@memsharded memsharded merged commit c2595fb into conan-io:develop Dec 14, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 14, 2018

@memsharded memsharded deleted the memsharded:feature/visjs branch Dec 14, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.