Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2 schema and refactor of client/server URLs #4138

Merged

Conversation

Projects
None yet
2 participants
@lasote
Copy link
Contributor

commented Dec 14, 2018

Changelog: Bugfix: Fixed bad URL schema in ApiV2 that could cause URLs collisions

Sorry for the refactor, I know it shouldn't be so big for a minor, but I think now it is much clear and safer the url schema both in the client and the server.

All the URLs are declared in model/rest_routes.py and the client and server use them to construct the correct paths.

@ghost ghost assigned lasote Dec 14, 2018

@ghost ghost added the stage: review label Dec 14, 2018

@lasote lasote added this to the 1.10.2 milestone Dec 17, 2018

@lasote lasote assigned memsharded and unassigned lasote Dec 17, 2018

@ghost ghost assigned lasote Dec 17, 2018

@lasote lasote merged commit 95321eb into conan-io:release/1.10.2 Dec 17, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 17, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Fix v2 schema and refactor of client/server URLs (conan-io#4138)
* Refactor and new endpoint

* Fixed bug

* Bug

* Simplified hierarchy

* Fixed code

* Fixing more stuff

* First test revisions

* Fixed revisions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.