Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config install requester for download #4172

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Dec 19, 2018

Changelog: BugFix: Fix conan config install requester for zip file download
Docs: omit

  • Refer to the issue that supports this Pull Request: closes #4169
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.11.1 milestone Dec 19, 2018

@ghost ghost assigned danimtb Dec 19, 2018

@ghost ghost added the stage: review label Dec 19, 2018

@danimtb danimtb removed their assignment Dec 19, 2018

@lasote

lasote approved these changes Dec 19, 2018

@lasote lasote merged commit e4c5cc2 into conan-io:release/1.11.1 Dec 19, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Dec 19, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Fix config install requester for download (conan-io#4172)
* Add test

* Fix config install requester for download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.