Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Contributing guidelines and added docs and stages information #4173

Merged
merged 5 commits into from Dec 21, 2018

Conversation

@danimtb
Copy link
Member

@danimtb danimtb commented Dec 19, 2018

Changelog: Fix: Updated contributing guidelines to the new workflow
Docs: omit

This updated the contributing guidelines including information about added docs PRs and issue stages.

@ghost ghost assigned danimtb Dec 19, 2018
@ghost ghost added the stage: review label Dec 19, 2018
@danimtb danimtb assigned jgsogo and unassigned danimtb Dec 19, 2018
@danimtb danimtb requested review from lasote and memsharded Dec 19, 2018
lasote
lasote approved these changes Dec 20, 2018
@danimtb
Copy link
Member Author

@danimtb danimtb commented Dec 20, 2018

I think it could be useful to have them linked in the readme so they are easier to find

@ghost ghost assigned danimtb Dec 20, 2018
@danimtb danimtb removed their assignment Dec 20, 2018
jgsogo
jgsogo approved these changes Dec 20, 2018
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-Authored-By: danimtb <danimanzaneque@gmail.com>
@ghost ghost assigned danimtb Dec 20, 2018
Co-Authored-By: danimtb <danimanzaneque@gmail.com>
@danimtb danimtb removed their assignment Dec 20, 2018
@danimtb danimtb added this to the 1.12 milestone Dec 21, 2018
@danimtb danimtb merged commit e03c60c into conan-io:develop Dec 21, 2018
2 checks passed
@ghost ghost removed the stage: review label Dec 21, 2018
grisumbras pushed a commit to grisumbras/conan that referenced this issue Dec 27, 2018
…on (conan-io#4173)

* Review of Contributing guidelines and added docs and stages information

* Use friendly view of contributing markdown

* Add contributing section to readme

* Update .github/CONTRIBUTING.md

Co-Authored-By: danimtb <danimanzaneque@gmail.com>

* Update .github/CONTRIBUTING.md

Co-Authored-By: danimtb <danimanzaneque@gmail.com>
NoWiseMan added a commit to NoWiseMan/conan that referenced this issue Jan 9, 2019
…on (conan-io#4173)

* Review of Contributing guidelines and added docs and stages information

* Use friendly view of contributing markdown

* Add contributing section to readme

* Update .github/CONTRIBUTING.md

Co-Authored-By: danimtb <danimanzaneque@gmail.com>

* Update .github/CONTRIBUTING.md

Co-Authored-By: danimtb <danimanzaneque@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants