Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/use env in package command #4204

Merged

Conversation

Projects
None yet
2 participants
@grisumbras
Copy link
Contributor

commented Dec 27, 2018

fixes #4198

Changelog: Bugfix: Apply the environment to the local conan package command
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
@memsharded
Copy link
Contributor

left a comment

This looks great, thank you!

The only thing, I think the test is mostly about the "conan package" test, than a "conan_api" test. Not testing the api itself, but testing the local "package" behavior. But don't worry, I'll merge it, and if anything move it later. Good job!

@memsharded memsharded added this to the 1.12 milestone Dec 28, 2018

@memsharded memsharded merged commit 84631c0 into conan-io:develop Dec 28, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

NoWiseMan added a commit to NoWiseMan/conan that referenced this pull request Jan 9, 2019

Feature/use env in package command (conan-io#4204)
* test for package command using recipe's environment

* package command uses recipe's environment

fixes conan-io#4198

* fixed test for Windows paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.