Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version_checker from client #4205

Merged
merged 5 commits into from Jan 2, 2019
Merged

Remove version_checker from client #4205

merged 5 commits into from Jan 2, 2019

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Dec 27, 2018

Changelog: Fix: Remove client/server versions check on every request. Return server capabilities only in ping endpoint.

Docs: omit

closes #4171 (I think I have understood well the intention in the issue)

@tags: svn, slow
@revisions: 1

@ghost ghost assigned jgsogo Dec 27, 2018
@ghost ghost added the stage: review label Dec 27, 2018
conans/client/rest/rest_client.py Outdated Show resolved Hide resolved
Copy link
Member

@memsharded memsharded left a comment

Nice cleanup. I'd wait for @lasote feedback on the VersionCheckerPlugin.

conans/server/rest/bottle_plugins/version_checker.py Outdated Show resolved Hide resolved
@memsharded memsharded assigned lasote and unassigned jgsogo Dec 28, 2018
@memsharded memsharded added this to the 1.12 milestone Dec 28, 2018
@ghost ghost assigned jgsogo Jan 2, 2019
lasote
lasote approved these changes Jan 2, 2019
@jgsogo jgsogo removed their assignment Jan 2, 2019
@jgsogo jgsogo merged commit 46e76d0 into conan-io:develop Jan 2, 2019
2 checks passed
@ghost ghost removed the stage: review label Jan 2, 2019
@jgsogo jgsogo deleted the issue/4171 branch Jan 2, 2019
NoWiseMan added a commit to NoWiseMan/conan that referenced this issue Jan 9, 2019
* remove references to client/server versions

* remove 'VersionCheckerPlugin', keep functionality in 'ping' controler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants