Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update premake generator, rename conanbuildinfo.premake -> conanbuildinfo.premake.lua, conan_cppdefines -> conan_defines #4296

Merged
merged 2 commits into from Jan 19, 2019

Conversation

@SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 14, 2019

closes #4286

Changelog: Fix: Update premake generator, rename conanbuildinfo.premake -> conanbuildinfo.premake.lua, conan_cppdefines -> conan_defines
Docs: conan-io/docs#1032

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

/cc @solvingj

SSE4 added 2 commits Jan 14, 2019
Signed-off-by: SSE4 <tomskside@gmail.com>
…xxflags

Signed-off-by: SSE4 <tomskside@gmail.com>
@ghost ghost assigned SSE4 Jan 14, 2019
@ghost ghost added the stage: review label Jan 14, 2019
@SSE4 SSE4 changed the title Update premake generator Fix: Update premake generator Jan 14, 2019
Copy link
Member

@danimtb danimtb left a comment

Suggestions according to #4286 (comment)

@danimtb danimtb added this to the 1.12 milestone Jan 15, 2019
@danimtb
Copy link
Member

@danimtb danimtb commented Jan 15, 2019

Please make a PR to the docs with this new information and provide a meaningful changelog (important as this would be """breaking""" for premake users)

@SSE4 SSE4 changed the title Fix: Update premake generator Fix: Update premake generator, rename conanbuildinfo.premake -> conanbuildinfo.premake.lua, conan_cppdefines -> conan_defines Jan 15, 2019
@lasote lasote assigned memsharded and unassigned SSE4 Jan 17, 2019
@lasote
Copy link
Contributor

@lasote lasote commented Jan 17, 2019

ping @SSE4 missing docs

@lasote
Copy link
Contributor

@lasote lasote commented Jan 18, 2019

As @danimtb said in a resolved comment:

Finally we agreed on having cpp_info.cppflags converted to conan_cxxflags. So no further action is required.

So, do you need something more to write the docs? @SSE4

@SSE4
Copy link
Contributor Author

@SSE4 SSE4 commented Jan 18, 2019

@SSE4 no, I'll add docs ASAP

@SSE4
Copy link
Contributor Author

@SSE4 SSE4 commented Jan 19, 2019

added docs

@memsharded memsharded merged commit fd938f7 into conan-io:develop Jan 19, 2019
2 checks passed
@ghost ghost removed the stage: review label Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants