Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git.get_tag() and svn.get_tag() #4306

Merged
merged 9 commits into from Jan 17, 2019

Conversation

Projects
None yet
4 participants
@danimtb
Copy link
Member

commented Jan 15, 2019

Changelog: Feature: Added get_tag() methods to tools.Git() and tools.SVN() helpers.
Changelog: Fix: get_branch() method of tools.SVN() helper now returns only the branch name, not the tag when present.
Docs: conan-io/docs#1020

@tags: svn, slow

  • Refer to the issue that supports this Pull Request: closes #3987
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@ghost ghost assigned danimtb Jan 15, 2019

@ghost ghost added the stage: review label Jan 15, 2019

danimtb added some commits Jan 15, 2019

@danimtb danimtb assigned jgsogo and unassigned danimtb Jan 16, 2019

@danimtb danimtb requested a review from jgsogo Jan 16, 2019

@danimtb danimtb added this to the 1.12 milestone Jan 16, 2019

@jgsogo
Copy link
Member

left a comment

Does it work with lightweight tags?

Show resolved Hide resolved conans/test/unittests/util/tools_test.py Outdated
Show resolved Hide resolved conans/test/unittests/util/tools_test.py

@ghost ghost assigned danimtb Jan 16, 2019

@danimtb danimtb removed their assignment Jan 16, 2019

@jgsogo
Copy link
Member

left a comment

Just two typos, and... can we add a test that raises?

Show resolved Hide resolved conans/test/unittests/util/tools_test.py Outdated
Show resolved Hide resolved conans/test/unittests/util/tools_test.py Outdated

@ghost ghost assigned danimtb Jan 16, 2019

@danimtb danimtb removed their assignment Jan 16, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

@danimtb, what about the test that raises from get_branch and/or get_tag?

@lasote

lasote approved these changes Jan 17, 2019

@danimtb danimtb removed their assignment Jan 17, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

This PR is breaking previous behavior. Although I'm agree that that current one is the good one, I want to be sure that you are aware of it (ping @conan-io/barbarians):

https://github.com/conan-io/conan/pull/4306/files#diff-4d836661d105934362de1c311c59ce8cR1882

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Jan 17, 2019

Yes, it was not consistent with git.get_branch() behavior, which is only returning the version name

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Thanks for the observation @jgsogo. I also agree it is better now. Fortunately, scm is still experimental because only the usage brings the knowledge.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

only the usage brings the knowledge

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

SCM is experimental, tools.SVN isn't (https://docs.conan.io/en/latest/reference/tools.html#tools-svn).... but, I vote for changing it

@lasote

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

It is experimental, change the docs.

@jgsogo

jgsogo approved these changes Jan 17, 2019

@jgsogo jgsogo merged commit 6ac12b4 into conan-io:develop Jan 17, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.