Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable profiles #4308

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Projects
None yet
4 participants
@lasote
Copy link
Contributor

commented Jan 15, 2019

Changelog: Feature: The commands conan install, conan info, conan create and conan export-pkg now can receive multiple profile arguments. The applied profile will be the composition of them, prioritizing the latest applied.

Docs: conan-io/docs#1036

Closes #4141

@lasote lasote added this to the 1.12 milestone Jan 15, 2019

@lasote lasote requested review from jgsogo, danimtb and memsharded Jan 15, 2019

@ghost ghost assigned lasote Jan 15, 2019

@ghost ghost added the stage: review label Jan 15, 2019

@lasote lasote assigned danimtb and unassigned danimtb and lasote Jan 15, 2019

@jgsogo
Copy link
Member

left a comment

Just check the Extender order, please.

Also, profiles can have includes, but it shouldn't affect, right? ...as includes are resolved first and the one-and-only profile is composed after.

@memsharded
Copy link
Contributor

left a comment

Looking good and useful!

@jgsogo
Copy link
Member

left a comment

Approve, but waiting for docs

@danimtb

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Would it be worth adding a test with a profile B that includes a profile A and then call in command line conan create . user/channel --profile B --profile A? I would expect this having the same effect as conan create . user/channel --profile A with the additional things of B

I think it is worth a test definitely

@ghost ghost assigned lasote Jan 21, 2019

@danimtb
Copy link
Member

left a comment

Looking good! 👍 Please include the 📝

@lasote lasote referenced this pull request Jan 21, 2019

Merged

profile composition #1036

@lasote lasote removed their assignment Jan 21, 2019

Added docs

@danimtb danimtb merged commit 665183a into conan-io:develop Jan 21, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.