Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator template #4358

Merged
merged 1 commit into from Jan 23, 2019
Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Jan 22, 2019

Changelog: Bugfix: Custom generator allow to use imports
Docs: conan-io/docs#1043

Close #3744

@ghost ghost assigned memsharded Jan 22, 2019
@ghost ghost added the stage: review label Jan 22, 2019
@memsharded memsharded added this to the 1.12 milestone Jan 22, 2019
lasote
lasote approved these changes Jan 22, 2019
Copy link
Contributor

@lasote lasote left a comment

While @solvingj agree, I'm ok with this implementation.

@memsharded memsharded assigned lasote and unassigned memsharded Jan 22, 2019
@solvingj
Copy link
Contributor

@solvingj solvingj commented Jan 22, 2019

thanks for the ping, fine by me.

@memsharded memsharded merged commit e1472d7 into conan-io:develop Jan 23, 2019
2 checks passed
@memsharded memsharded deleted the feature/generator_template branch Jan 23, 2019
@ghost ghost removed the stage: review label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants