Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CONAN_CPU_COUNT and output user friendly error message #4372

merged 1 commit into from Jan 24, 2019


Copy link

@dstftw dstftw commented Jan 23, 2019

Changelog: Fix: Validate CONAN_CPU_COUNT and output user-friendly message for invalid values
Docs: omit
Closes #4371

  • Refer to the issue that supports this Pull Request. Fixes #4371.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
Copy link

@CLAassistant CLAassistant commented Jan 23, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@uilianries uilianries left a comment


@lasote lasote added this to the 1.12 milestone Jan 24, 2019
@lasote lasote requested a review from memsharded Jan 24, 2019
Copy link

@memsharded memsharded commented Jan 24, 2019

I would have probably used Exceptions as a slightly more python-idiomatic way to do this, but this is perfect too. Many thanks for contributing this fix!

@memsharded memsharded merged commit b28d665 into conan-io:develop Jan 24, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants