Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double application of env vars from profile #4380

Merged
merged 10 commits into from Jan 28, 2019

Merge branch 'develop' into fix/profile_env

  • Loading branch information...
danimtb committed Jan 25, 2019
commit 38337b101dd2bf8d3bc0a511dbce4fe3163da677
@@ -50,6 +50,14 @@ def profile_conanfile_txt_test(self):
package_env={"Hello0": [("OTHER_VAR", "2")]})
self.client.run("install . -pr envs -g virtualenv")
This conversation was marked as resolved by danimtb

This comment has been minimized.

Copy link
@memsharded

memsharded Jan 25, 2019

Contributor

Not sure what this test is testing.


def test_profile_relative_cwd(self):
self.client.save({"conanfile.txt": "", "sub/sub/profile": ""})
self.client.current_folder = os.path.join(self.client.current_folder, "sub")
self.client.run("install .. -pr=sub/profile2", assert_error=True)
self.assertIn("ERROR: Profile not found: sub/profile2", self.client.out)
self.client.run("install .. -pr=sub/profile")
self.assertIn("conanfile.txt: Installing package", self.client.out)

def base_profile_generated_test(self):
"""we are testing that the default profile is created (when not existing, fresh install)
even when you run a create with a profile"""
You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.