Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Wrong param in function `search_packages` #4502

Merged
merged 3 commits into from Feb 18, 2019

Conversation

Projects
None yet
4 participants
@jgsogo
Copy link
Member

commented Feb 11, 2019

Changelog: Bugfix: Fix search packages function when remote is called all
Docs: omit

It looks like users do not name their remotes as all...

@ghost ghost assigned jgsogo Feb 11, 2019

@ghost ghost added the stage: review label Feb 11, 2019

@jgsogo jgsogo changed the title bufix: Wrong param in function bugfix: Wrong param in function `search_packages` Feb 11, 2019

@jgsogo jgsogo requested a review from danimtb Feb 11, 2019

@memsharded memsharded added this to the 1.13 milestone Feb 11, 2019

@lasote

lasote approved these changes Feb 13, 2019

@danimtb

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

In case we release a a new 1.12 patch, we could re-target this PR to that branch

@danimtb danimtb modified the milestones: 1.13, 1.12.3 Feb 15, 2019

@danimtb danimtb changed the base branch from develop to release/1.12.3 Feb 15, 2019

@jgsogo jgsogo changed the base branch from release/1.12.3 to develop Feb 15, 2019

@jgsogo jgsogo force-pushed the jgsogo:fix/wrong-param branch from 40e6fe6 to b776744 Feb 18, 2019

@jgsogo jgsogo changed the base branch from develop to release/1.12.3 Feb 18, 2019

@memsharded memsharded merged commit a6726d2 into conan-io:release/1.12.3 Feb 18, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Feb 18, 2019

@jgsogo jgsogo deleted the jgsogo:fix/wrong-param branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.