Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Anonymous user behavior + Artifactory test framework #4526

Merged
merged 93 commits into from Feb 18, 2019

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Feb 15, 2019

Changelog: Fix: Fixed issue with Artifactory when the anonymous user is enabled, causing the uploads to fail without requesting the user and password.
Docs: omit

  • new Artifactory test server framework, only used with "revisions_test", other tests might have more "server checks" that would need to be implemented.
  • To enable the artifactory server automatically you can use CONAN_TEST_WITH_ARTIFACTORY=1
  • Fixed issue with Artifactory when the anonymous user is enabled. The "check_credentials" endpoint returns ok but then the upload returns "403" instead of "401" causing Conan to crash without requesting user and password.
@lasote lasote added this to the 1.13 milestone Feb 15, 2019
@lasote lasote requested a review from memsharded Feb 15, 2019
@ghost ghost assigned lasote Feb 15, 2019
@ghost ghost added the stage: review label Feb 15, 2019
@lasote lasote marked this pull request as ready for review Feb 15, 2019
Copy link
Member

@memsharded memsharded left a comment

Cool. Fix that duplicated Exception and merge.

conans/errors.py Outdated
@@ -94,6 +94,10 @@ class NoRestV2Available(ConanException):
pass


class NoRestV2Available(ConanException):
Copy link
Member

@memsharded memsharded Feb 15, 2019

Duplicated? Merge error?

@lasote lasote merged commit 26b327f into conan-io:develop Feb 18, 2019
2 checks passed
@ghost ghost removed the stage: review label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants