Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use Jinja2 to parse layout files (editable packages) #4596
Changelog: Feature: Apply Jinja2 to layout files before parsing them
This PR executes Jinja2 over layout files (context contains
Running on more python versions as we are introducing a new dependency:
referenced this pull request
Feb 26, 2019
memsharded left a comment
This PR is difficult to review. Many tests changed, too many refactors and things moved. It is difficult to know if some other functionality rather than introducing Jinja2 has been changed.
It would be better to keep functional PR to the minimum changeset possible, and then refactor later in a pure refactor PR.
These are just the needed changes:
If the functionality has changed, the unittest change, there is no diff suitable for them.