Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONAN_XXX_ROOT variables to cmake_paths generator #4719

Merged
merged 3 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Mar 12, 2019

Changelog: Fix: The cmake_paths generator now declares the CONAN_XXX_ROOT variables in case some exported cmake module file like XXXConfig.cmake has been patched with the cmake.patch_config_paths() to replace absolute paths to the local cache.

Docs: conan-io/docs#1115
Closes #4467

@lasote lasote added this to the 1.14 milestone Mar 12, 2019

@lasote lasote requested a review from danimtb Mar 12, 2019

@ghost ghost assigned lasote Mar 12, 2019

@ghost ghost added the stage: review label Mar 12, 2019

@lasote lasote referenced this pull request Mar 12, 2019

Merged

cmake paths ROOT paths #1115

@lasote lasote removed their assignment Mar 12, 2019

@ghost ghost assigned lasote Mar 12, 2019

@danimtb

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Please update this PR to the latest changes in develop branch

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

good to go, solve conflicts and merge

@lasote lasote merged commit 06261ab into conan-io:develop Mar 15, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.