Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify revision_mode for each recipe #4767

Merged
merged 11 commits into from Mar 25, 2019

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 19, 2019

Changelog: Feature: Allow to specify revision_mode for each recipe, values accepted are scm or hash (default)
Docs: conan-io/docs#1126

  • closes #4413: revision mode per recipe
  • closes #4728: default revision mode is hash
@ghost ghost assigned jgsogo Mar 19, 2019
@ghost ghost added the stage: review label Mar 19, 2019
@jgsogo jgsogo added this to the 1.14 milestone Mar 19, 2019
@jgsogo jgsogo changed the title Issue/4413 revision mode Allow to specify revision_mode for each recipe Mar 19, 2019
@jgsogo jgsogo marked this pull request as ready for review Mar 19, 2019
@jgsogo jgsogo requested a review from lasote Mar 19, 2019
Copy link
Member

@danimtb danimtb left a comment

Looking good. Just a missing test case IMO

conans/test/functional/command/export_test.py Show resolved Hide resolved
@jgsogo jgsogo dismissed danimtb’s stale review Mar 20, 2019

"auto" has been deprecated as revision_mode

conans/test/functional/command/export_test.py Outdated Show resolved Hide resolved
@memsharded memsharded assigned lasote and unassigned jgsogo and danimtb Mar 24, 2019
@lasote lasote merged commit b9a7696 into conan-io:develop Mar 25, 2019
2 checks passed
@ghost ghost removed the stage: review label Mar 25, 2019
@jgsogo jgsogo deleted the issue/4413-revision_mode branch Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants