Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
#4696: Build-Mode pattern now covers the whole reference #4787
Not sure if this is considered breaking:
With the new implementation it will take the whole package reference an fnmatches it. Therefore the new implementation will match both references. This is a different behaviour like before.
The implementation works like expected with things like
referenced this pull request
Mar 20, 2019
I'm not sure about (examples taken from the tests)
But It is just an opinion, I haven't checked previous behavior...
The test that is failing is associated with one our comments above: "H" should not match "Hey/0.1@user/testing". I think that we only need two lines for this functionality to work:
for pattern in self.patterns: is_matching_name = fnmatch.fnmatch(ref.name, pattern) is_matching_ref = fnmatch.fnmatch(repr(ref), pattern) if is_matching_name or is_matching_ref: ...