Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scm no commit #4830

Merged
merged 3 commits into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Mar 26, 2019

Changelog: Bugfix: Revision computation failed when a git repo was present but without commits
Docs: omit
@revisions: 1

@lasote lasote added this to the 1.13.3 milestone Mar 26, 2019

@ghost ghost assigned lasote Mar 26, 2019

@ghost ghost added the stage: review label Mar 26, 2019

@lasote lasote requested a review from memsharded Mar 26, 2019

@@ -53,7 +53,7 @@ def run(self, command):
with chdir(self.folder) if self.folder else no_op():
with environment_append({"LC_ALL": "en_US.UTF-8"}) if self._force_eng else no_op():
if not self._runner:
return decode_text(subprocess.check_output(command, shell=True).strip())
return decode_text(subprocess.check_output(command, shell=True, stderr=STDOUT).strip())

This comment has been minimized.

Copy link
@lasote

lasote Mar 26, 2019

Author Contributor

Printing the error in the terminal was awful

@lasote lasote assigned memsharded and unassigned lasote Mar 26, 2019

@lasote lasote requested a review from jgsogo Mar 26, 2019

@jgsogo

jgsogo approved these changes Mar 26, 2019

Copy link
Member

left a comment

Although I would move some logic to the _updat3e_revision_in_metadata function, I know the implementation has changed in develop, so it will be completely different there.

Show resolved Hide resolved conans/client/cmd/export.py Outdated

@ghost ghost assigned lasote Mar 26, 2019

@jgsogo

jgsogo approved these changes Mar 26, 2019

@lasote lasote merged commit b6b6d11 into conan-io:release/1.13.3 Mar 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.