Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run 'export_sources' automatically for python_requires #4838

Merged

Conversation

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 26, 2019

Changelog: Fix: Do not run export_sources automatically for python_requires
Docs: omit

Removes the automatic export of the files listed in python_requires::exports_sources. This was an undocumented behavior that was not being executed in the local workflow, and we have thought that it can lead the user to unexpected results.

Implement part of #4340

@ghost ghost assigned jgsogo Mar 26, 2019
@ghost ghost added the stage: review label Mar 26, 2019
@jgsogo jgsogo added this to the 1.14 milestone Mar 26, 2019
lasote
lasote approved these changes Mar 26, 2019
@memsharded memsharded merged commit 4214226 into conan-io:develop Mar 26, 2019
2 checks passed
@ghost ghost removed the stage: review label Mar 26, 2019
@jgsogo jgsogo deleted the issue/4262-pyreq-no-export-source branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants