Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message for unknown errors building the API and collaborators #4869

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Mar 29, 2019

Changelog: Fix: Print a message for unhandled Conan errors building the API and collaborators
Docs: omit

@ghost ghost assigned jgsogo Mar 29, 2019

@ghost ghost added the stage: review label Mar 29, 2019

@jgsogo jgsogo requested a review from memsharded Mar 29, 2019

@jgsogo jgsogo added this to the 1.14.1 milestone Mar 29, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

I'm merging this to the 1.14.1 but we usually don't introduce fixes (but not bugfixes) or at least not fixes closing a reported issue. IMHPOV this fix should have been open to develop, to keep the minor releases with low risk to introduce new bugs with the changes. Anyway, that's not very important. Good job with this.

@lasote lasote merged commit 6823464 into conan-io:release/1.14.1 Mar 31, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 31, 2019

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

This PR was targeting develop (in fact, here it is: #4863), but I was asked to make it against v1.14.1 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.