Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry upload or download for error in response message #4984

Merged
merged 1 commit into from May 21, 2019

Conversation

@climblinne
Copy link
Contributor

@climblinne climblinne commented Apr 15, 2019

Change-Id: Ic1c1814b6e5f46dec8b7e1ffd0661ae619a01ca1

Changelog: Feature: Retry upload or download for error in response message (e.g. status is '500')
Docs: omit

Close #4907

  • Refer to the issue: #4907
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

I added a first fix for the issue in #4907.

@climblinne climblinne force-pushed the issue-4907 branch 2 times, most recently from 2f77e5d to 4a59d38 Apr 15, 2019
@climblinne
Copy link
Contributor Author

@climblinne climblinne commented May 8, 2019

@memsharded Why is the build getting an "Cause: jenkins.branch.BranchIndexingCause" error?

@memsharded
Copy link
Member

@memsharded memsharded commented May 8, 2019

@climblinne

That is a Jenkins error, I will re-launch Jenkins build

@climblinne
Copy link
Contributor Author

@climblinne climblinne commented May 8, 2019

@jgsogo Code you do a review? I added your tests into the PR. Thanks

Copy link
Member

@memsharded memsharded left a comment

Thanks for the contribution, I think it makes sense and could be merged.

@lasote lasote added this to the 1.16 milestone May 9, 2019
jgsogo
jgsogo approved these changes May 13, 2019
Copy link
Member

@jgsogo jgsogo left a comment

I think this PR should close #4907, right?

@climblinne
Copy link
Contributor Author

@climblinne climblinne commented May 13, 2019

I think this PR should close #4907, right?

Yes

@lasote lasote merged commit cd56d52 into conan-io:develop May 21, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants