Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip symlink checks #4991

Merged
merged 2 commits into from Apr 23, 2019
Merged

Conversation

@lasote
Copy link
Contributor

@lasote lasote commented Apr 17, 2019

Changelog: Feature: You can disable broken symlinks checks when packaging using CONAN_SKIP_BROKEN_SYMLINKS_CHECK env var or config.skip_broken_symlinks_check=1
Docs: conan-io/docs#1272

Closes #4990

@lasote lasote added this to the 1.15 milestone Apr 17, 2019
@lasote lasote requested a review from memsharded Apr 17, 2019
@ghost ghost assigned lasote Apr 17, 2019
@ghost ghost added the stage: review label Apr 17, 2019
conans/util/files.py Outdated Show resolved Hide resolved
raise ConanException("The file is a broken symlink, verify that "
"you are packaging the needed destination files: '%s'"
% abs_path)
if not get_env("CONAN_SKIP_BROKEN_SYMLINKS_CHECK", False):
Copy link
Member

@memsharded memsharded Apr 17, 2019

What if we completely remove this check? Would it be breaking behavior?

Copy link
Contributor Author

@lasote lasote Apr 22, 2019

I don't think it would be breaking behavior. The question is if this check is avoiding some headaches when the broken symlinks are not intended or not. To be honest, I don't know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants