Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_package_id_mode in the default conan.conf (#4974) #5005

Merged

Conversation

Projects
None yet
2 participants
@uilianries
Copy link
Member

commented Apr 18, 2019

  • Add default_package_id_mode into default conan.conf
  • Add env var CONAN_DEFAULT_PACKAGE_ID_MODE
  • Set default value to semver_direct_mode
  • Update Functional tests to validate the env var

fixes #4974

Changelog: Fix: Add default_package_id_mode in the default conan.conf (#4947)
Docs: conan-io/docs#1248

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#4974 default_package_id_mode is in the default conan.conf
- Add default_package_id_mode into default conan.conf
- Add env var CONAN_DEFAULT_PACKAGE_ID_MODE
- Set default value to semver_direct_mode
- Update Functional tests to validate the env var

Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Apr 18, 2019

@ghost ghost added the stage: review label Apr 18, 2019

@memsharded memsharded added this to the 1.15 milestone Apr 19, 2019

@memsharded memsharded merged commit 49722b9 into conan-io:develop Apr 19, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.