Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check manifest and consider the file corrupted #5012

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@lasote
Copy link
Contributor

commented Apr 22, 2019

Changelog: Bugfix: Fixed a bug that intermittently raised ERROR: 'NoneType' object has no attribute 'file_sums' when uploading a recipe.
Docs: omit

Close #4953
Close #5009

Check if the remote recipe manifest is None before comparing with the local one.
It could be caused because:

a) Concurrency issue, maybe when we read the manifest it is None but later the snapshot is != None because the recipe might be being uploaded in a concurrent process. (Matches the symptoms)
b) Remote recipe corruption, where there is no manifest upload.

I would say the "a" is the most plausible reason. So now the client will consider that it has to upload all the contents again.

@lasote lasote added this to the 1.14.4 milestone Apr 22, 2019

@lasote lasote requested a review from memsharded Apr 22, 2019

@ghost ghost assigned lasote Apr 22, 2019

@ghost ghost added the stage: review label Apr 22, 2019

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Superseded by #5014

@memsharded memsharded closed this Apr 24, 2019

@ghost ghost removed the stage: review label Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.