Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent uploads checks and tests #5014

Merged

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Apr 22, 2019

Changelog: Bugfix: Solved errors in concurrent uploads of same recipe
Docs: omit

Close #4953
Close #5009

Branched from #5012, but:

  • Delayed _check_recipe_date AFTER compressing the zip, so it is closer to snapshot
  • Avoiding loading local manifest twice
  • If remote_manifest not there, try to get it in a later attempt
  • New test with a patch to simulate exactly the concurrent behavior

@tags: slow

@ghost ghost assigned memsharded Apr 22, 2019

@ghost ghost added the stage: review label Apr 22, 2019

@memsharded memsharded added this to the 1.14.4 milestone Apr 22, 2019

memsharded added some commits Apr 22, 2019

@memsharded memsharded assigned lasote and unassigned memsharded Apr 23, 2019

@lasote

lasote approved these changes Apr 23, 2019

@memsharded memsharded merged commit 1bb2a3c into conan-io:release/1.14.4 Apr 24, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Apr 24, 2019

@memsharded memsharded deleted the memsharded:hotfix/concurrent_uploads branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.