Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vs2019+ninja #5028

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Apr 25, 2019

Changelog: Bugfix: Fixed error while using Visual Studio 2019 with Ninja generator.
Docs: Omit

Close #5025
Close #4977

@DoDoENT I opened a new PR adding a test and fixing some PEP8 rules, I won't squash it to preserve your commits. Thanks!

DoDoENT and others added some commits Apr 24, 2019

when determining whether generator contains platform, use information…
… about generator, as well as information about compiler

@ghost ghost assigned lasote Apr 25, 2019

@ghost ghost added the stage: review label Apr 25, 2019

@lasote lasote added this to the 1.14.4 milestone Apr 25, 2019

@memsharded memsharded merged commit 04c2a5e into conan-io:release/1.14.4 Apr 25, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Apr 25, 2019

@DoDoENT

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Thank you! I wasn't using python linter in my editor. And also thanks for adding the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.