Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSBuild. parameter to skip toolset adjustement #5052

Merged
merged 2 commits into from Apr 29, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented Apr 29, 2019

Changelog: Feature: The MSBuild build helper allows the parameter toolset with False value to skip the toolset adjustment.
Docs: conan-io/docs#1260

Closes #4975

@ghost ghost assigned lasote Apr 29, 2019

@ghost ghost added the stage: review label Apr 29, 2019

@lasote lasote added this to the 1.15 milestone Apr 29, 2019

@lasote lasote removed their assignment Apr 29, 2019

@lasote lasote requested a review from danimtb Apr 29, 2019

@lasote lasote requested a review from memsharded Apr 29, 2019

@@ -152,6 +152,34 @@ def default_toolset_test(self, compiler_version, expected_toolset):
command = msbuild.get_command("project_should_flags_test_file.sln")
self.assertIn('/p:PlatformToolset="%s"' % expected_toolset, command)

def skip_toolset_test(self):

This comment has been minimized.

Copy link
@memsharded

memsharded Apr 29, 2019

Contributor

Test failing in Linux because not VS

@ghost ghost assigned lasote Apr 29, 2019

@memsharded memsharded merged commit f377de2 into conan-io:develop Apr 29, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.