Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed problem with transitive build_requires #5056

Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Apr 29, 2019

Changelog: Bugfix: Fixing exception of transitive build-requires mixed with normal requires
Docs: omit

Close #5043
Address #4987 (comment)

@tags: slow

jgsogo
jgsogo approved these changes Apr 30, 2019
@@ -148,6 +148,7 @@ def _handle_require(self, name, node, require, dep_graph, check_updates, update,
new_node.inverse_closure.add(node)
node.public_deps[new_node.name] = new_node

new_node.build_require = node.build_require or require.build_require
Copy link
Contributor

@lasote lasote Apr 30, 2019

I had to postpone #4738 for 1.16, but please, at least put a comment if the code is new. That is a new corner case that it is impossible for anyone except you to know why. What does it mean that node.build_require is None and why it should take it from require? What is require?

Copy link
Member Author

@memsharded memsharded Apr 30, 2019

Done

@ghost ghost assigned memsharded Apr 30, 2019
@lasote lasote merged commit 92789b1 into conan-io:release/1.14.5 Apr 30, 2019
2 checks passed
@ghost ghost removed the stage: review label Apr 30, 2019
lasote
lasote approved these changes Apr 30, 2019
@memsharded memsharded deleted the hotfix/build_require_transitive branch Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants