Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for editable declaring build_folder #5070

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@memsharded
Copy link
Contributor

commented Apr 30, 2019

Changelog: Bugfix: Don't crash when an editable declare a build_folder in the layout, but not used in a workspace
Docs: omit

Close #4819

@ghost ghost assigned memsharded Apr 30, 2019

@ghost ghost added the stage: review label Apr 30, 2019

@memsharded memsharded added this to the 1.15 milestone Apr 30, 2019

@memsharded memsharded requested a review from jgsogo Apr 30, 2019

@memsharded memsharded assigned lasote and unassigned memsharded Apr 30, 2019

@jgsogo

jgsogo approved these changes Apr 30, 2019

Copy link
Member

left a comment

More elegant than the proposed patch 👍

@lasote lasote merged commit d23d481 into conan-io:develop May 3, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label May 3, 2019

@memsharded memsharded deleted the memsharded:feature/editable_build_folder branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.