Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check C library with new default 'compiler.cppstd' behavior #5075

Closed

Conversation

Projects
None yet
1 participant
@jgsogo
Copy link
Member

commented May 1, 2019

Changelog: omit
Docs: omit

Note.- Not to be merged, changes (if needed) should go through #4917.

This PR evaluates the examples introduced in #5074 with the new behavior given the compiler.cppstd subsetting: it is introducing the default value always. Tries to validate (or not) this comment: #4917 (comment)

jgsogo added some commits Apr 5, 2019

use cppstd=17 as it is also supported for Visual Studio (when running…
… tests in Windows it is the compiler by default)

jgsogo added some commits Apr 29, 2019

@ghost ghost assigned jgsogo May 1, 2019

@ghost ghost added the stage: review label May 1, 2019

jgsogo added some commits May 1, 2019

Merge branch 'feat/4873-cppstd-subsetting-c-library' of github.com:jg…
…sogo/conan into feat/4873-cppstd-subsetting-c-library
@jgsogo

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

It fails as expected, only clang in Mac (why not in Linux?) using the CompilerArgsGenerator:

----Running------
> clang -x c main.c -m64 -O3 -DNDEBUG -stdlib=libc++ -std=gnu++98 -o app
-----------------
Logging command output to file '/private/var/folders/q7/t4y6pddn0v9g_ppvl6dhp1pw0000gp/T/tmp09lfg1y5conans/path with spaces/conan_run.log'
error: invalid argument '-std=gnu++98' not allowed with 'C/ObjC'
ERROR: conanfile.py: Error in build() method, line 17
	self.run(command.format(compiler_args))
	ConanException: Error 1 while executing clang -x c main.c -m64 -O3 -DNDEBUG -stdlib=libc++ -std=gnu++98 -o app
@jgsogo

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Not needed anymore.

@jgsogo jgsogo closed this May 3, 2019

@ghost ghost removed the stage: review label May 3, 2019

@jgsogo jgsogo deleted the jgsogo:feat/4873-cppstd-subsetting-check-c-lib branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.