Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelWithDebInfo and MinSizeRel (cmake_multi) #5221

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
3 participants
@lasote
Copy link
Contributor

commented May 27, 2019

Changelog: Bugfix: The cmake_multi generator was not managing correctly the RelWithDebInfo and MinSizeRel build types.
Docs: omit

Closes #5131

@tags: slow

@lasote lasote changed the title Bugfix/5131 RelWithDebInfo and MinSizeRel (cmake_multi) May 27, 2019

@lasote lasote requested a review from memsharded May 27, 2019

@memsharded memsharded added this to the 1.16 milestone May 27, 2019

@memsharded memsharded merged commit 50c6021 into conan-io:develop May 27, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@@ -698,12 +710,19 @@ def _conan_basic_setup_common(addtional_macros, cmake_multi=False):
macro(conan_set_find_paths)
if(CMAKE_BUILD_TYPE)
MESSAGE("BUILD TYPE: ${CMAKE_BUILD_TYPE}")

This comment has been minimized.

Copy link
@lukastvrdy

lukastvrdy May 27, 2019

This variable is only meaningful to single-configuration generators (such as make and Ninja) i.e. those which choose a single configuration when CMake runs to generate a build tree as opposed to multi-configuration generators which offer selection of the build configuration within the generated build environment

Will this work for cmake_multi i.e. for CMake MSVC IDE generator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.