Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow other extensions to visual generator #5254

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented May 29, 2019

Changelog: Bugfix: visual_studio generator only adds ".lib" extension for lib names without extension, otherwise (like ".a") respect it.
Docs: omit

@tags: slow

@memsharded memsharded added this to the 1.16 milestone May 29, 2019

@lasote lasote merged commit ccabb74 into conan-io:develop May 30, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@memsharded memsharded deleted the memsharded:feature/allow_lib_extensions_visual_generator branch May 30, 2019

uilianries added a commit to uilianries/conan that referenced this pull request Jun 7, 2019

conan-io#5316 Regression for other Visual extensions
- Regrets conan-io#5254 to fix conan-io#5316

Signed-off-by: Uilian Ries <uilianries@gmail.com>

@uilianries uilianries referenced this pull request Jun 7, 2019

Merged

Regression of other extensions for Visual Studio (#5316) #5319

3 of 5 tasks complete

uilianries added a commit to uilianries/conan that referenced this pull request Jun 9, 2019

conan-io#5316 Regression for other Visual extensions
- Regrets conan-io#5254 to fix conan-io#5316

Signed-off-by: Uilian Ries <uilianries@gmail.com>

memsharded added a commit that referenced this pull request Jun 10, 2019

Regression of other extensions for Visual Studio (#5316) (#5319)
* #5316 Regression for other Visual extensions

- Regrets #5254 to fix #5316

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Rename extension method

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Update MSVC test

- Remove duplicated code

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Fix Visual Studio multi test

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* using .a extension too

* #5316 Using collect libs extensions

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Export valid library extensions

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Export lib ext as tuple

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #5316 Add extra test case

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.