Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better message for GCC OLD ABI COMPATIBILITY #5275

Merged
merged 2 commits into from Jun 3, 2019

Conversation

@Ignition
Copy link
Contributor

@Ignition Ignition commented Jun 1, 2019

Changelog: Fix: Better message for gcc warning of libstdc++ at default profile detection
Docs: omit

A simple usability and quality of life improvement. It is better to copy and paste a command given to you, rather than manual editing of a file.

Close #5273

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jun 1, 2019

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded self-assigned this Jun 2, 2019
@memsharded
Copy link
Member

@memsharded memsharded commented Jun 2, 2019

Hi @Ignition

There were failing tests, because that message was being tested. I have done some changes in https://github.com/memsharded/conan/tree/feature/gcc_msg

  • Fix the broken tests
  • Added to the message a note about editing manually with the full path, as the suggested message only works for profiles in the conan default cache location, but users can have profiles elsewhere.
  • Fixed some minor pep8 warnings

I have tried to push those changes to your branch or do a PR to your branch, but Github won't allow me (it typically does). Please take my changes from my branch and apply them to yours, so CI is green.

Thanks for your contribution!

Ignition and others added 2 commits Jun 3, 2019
A simple usability and quality of life improvement. It is better to copy and paste a command given to you, rather than manual editing of a file.
@memsharded memsharded merged commit f35a6b9 into conan-io:develop Jun 3, 2019
2 checks passed
@memsharded memsharded added this to the 1.17 milestone Jun 3, 2019
@memsharded
Copy link
Member

@memsharded memsharded commented Jun 3, 2019

Merged, to be released in 1.17, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants