Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/requirements_typed_ast #5324

Merged

Conversation

Projects
None yet
3 participants
@memsharded
Copy link
Contributor

commented Jun 9, 2019

Changelog: Fix: Constraint transitive dependency typed-ast (required by astroid) in python3.4, as they stopped releasing wheels, and it fails to build in some Windows platforms with older SDKs.
Docs: omit

Similar to #5301, but with conditionals

@PYVERS: py34

@memsharded memsharded added this to the 1.16.1 milestone Jun 10, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Run again with py34 (I've already done it)

Show resolved Hide resolved conans/requirements.txt
@jgsogo

jgsogo approved these changes Jun 10, 2019

Copy link
Member

left a comment

Ok, so it looks like platform_system=='Windows' and sys_platform=='win32' both work. Which one shall we use?

@memsharded

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Most checks in our codebase are done with platform.system()=='Windows', this is why I went for this one.

@jgsogo

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Changed also in #5301 to develop.

@lasote lasote merged commit 15ff10f into conan-io:release/1.16.1 Jun 11, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

lasote added a commit to lasote/conan that referenced this pull request Jun 11, 2019

memsharded added a commit that referenced this pull request Jun 11, 2019

@memsharded memsharded deleted the memsharded:hotfix/requirements_typed_ast branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.