Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix patch with strip #5334

Merged
merged 3 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Jun 11, 2019

Changelog: Bugfix: Allow creation and deletion of files in tools.patch with strip>0
Docs: omit

Close #5320

@memsharded memsharded referenced this pull request Jun 11, 2019

Closed

tools.patch cant create files #5320

3 of 3 tasks complete
@uilianries

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I gonna check with my gist from #5320

@uilianries
Copy link
Member

left a comment

LGTM

I can confirm it's working with patch file + strip=1

Tested using https://gist.github.com/uilianries/5532fcafcef88dad1ea4fd6e74b5670e

@memsharded memsharded added this to the 1.17 milestone Jun 11, 2019

@memsharded memsharded self-assigned this Jun 11, 2019

@memsharded memsharded merged commit f666653 into conan-io:develop Jun 11, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@memsharded memsharded deleted the memsharded:feature/fix_patch_with_strip branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.