Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix patch with strip #5334

Merged
merged 3 commits into from Jun 11, 2019
Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Jun 11, 2019

Changelog: Bugfix: Allow creation and deletion of files in tools.patch with strip>0
Docs: omit

Close #5320

@memsharded memsharded mentioned this pull request Jun 11, 2019
3 tasks
@uilianries
Copy link
Member

@uilianries uilianries commented Jun 11, 2019

I gonna check with my gist from #5320

Copy link
Member

@uilianries uilianries left a comment

LGTM

I can confirm it's working with patch file + strip=1

Tested using https://gist.github.com/uilianries/5532fcafcef88dad1ea4fd6e74b5670e

@memsharded memsharded added this to the 1.17 milestone Jun 11, 2019
@memsharded memsharded self-assigned this Jun 11, 2019
@memsharded memsharded merged commit f666653 into conan-io:develop Jun 11, 2019
2 checks passed
@memsharded memsharded deleted the feature/fix_patch_with_strip branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants