Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
#3447 Raise if info build-order and graph #5417
Retrieve dependencies graph from Conan API to generate html.
Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.
memsharded left a comment
While the original issue is right, there was something missing, I am not sure this is the best approach. I'd say that doing both things in the same command is relatively unlikely, they are very different things for different purposes. You want the build-order for CI mostly, and the HTML is basically for human-readable purposes.
I think that the future UI in Conan 2.0 will totally separate these concepts as different subcommands or something similar.
So breaking users for the value of this functionality... I am not fully convinced. I see @lasote approved, but just in case, wdyt?
If right now using both options doesn't produce the intended output it is a bug. But it can be considered a bug in either direction: it is a bug to allow those arguments without raising, or it is a bug to not produce the output. Having a look at the behavior of the function and how little those functionalities are correlated, I'd say go with the former, and thus avoid breaking the conan_api (as a side effect, if we need to break it, we can break it, but the benefit should be clear).