Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3447 Raise if info build-order and graph #5417

Merged

Conversation

Projects
None yet
3 participants
@uilianries
Copy link
Member

commented Jun 28, 2019

Retrieve dependencies graph from Conan API to generate html.

Changelog: Fix: Allow --build-order and --graph together for conan info (#3447)
Docs: Omit
fixes #3447

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#3447 Support info build-order and graph
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@lasote lasote added this to the 1.17 milestone Jul 1, 2019

@lasote lasote requested a review from memsharded Jul 1, 2019

@lasote

lasote approved these changes Jul 1, 2019

@memsharded
Copy link
Contributor

left a comment

While the original issue is right, there was something missing, I am not sure this is the best approach. I'd say that doing both things in the same command is relatively unlikely, they are very different things for different purposes. You want the build-order for CI mostly, and the HTML is basically for human-readable purposes.

I think that the future UI in Conan 2.0 will totally separate these concepts as different subcommands or something similar.

So breaking users for the value of this functionality... I am not fully convinced. I see @lasote approved, but just in case, wdyt?

Show resolved Hide resolved conans/client/conan_api.py Outdated
@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Why not prevent both options together? I mean, raising an error. I now, it's a breaking change, but for now we don't execute both commands together, but also we don't provide any message.

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

If right now using both options doesn't produce the intended output it is a bug. But it can be considered a bug in either direction: it is a bug to allow those arguments without raising, or it is a bug to not produce the output. Having a look at the behavior of the function and how little those functionalities are correlated, I'd say go with the former, and thus avoid breaking the conan_api (as a side effect, if we need to break it, we can break it, but the benefit should be clear).

@lasote
Copy link
Contributor

left a comment

@memsharded is right. The gain of this addition doesn't worth the possibility of breaking a CI from a user, even if the conan_api is not stable. I would say we should error for that combination of arguments.

@lasote lasote removed this from the 1.17 milestone Jul 2, 2019

uilianries added some commits Jul 2, 2019

#3447 Don't allow conan info -bo -g
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Done, Conan info won't be able to use --build-order + --graph

@memsharded memsharded added this to the 1.17 milestone Jul 2, 2019

@memsharded memsharded merged commit a890894 into conan-io:develop Jul 2, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@memsharded memsharded changed the title #3447 Support info build-order and graph #3447 Raise if info build-order and graph Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.