Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3953 Inspect -a shouln't raise AttributeError #5419

Merged
merged 1 commit into from Jun 29, 2019

Conversation

Projects
None yet
2 participants
@uilianries
Copy link
Member

commented Jun 28, 2019

When an attribute inspected by Conan is missing, is will be returned as empty

Changelog: Fix: Inspect missing attribute is not an error (#3953)
Docs: Omit
fixes #3953

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#3953 Inspect -a shouln't raise AttributeError
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@memsharded memsharded added this to the 1.17 milestone Jun 29, 2019

@memsharded memsharded merged commit 10a0bb3 into conan-io:develop Jun 29, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.