Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3943 Warning no_proxy as deprecated #5438

Merged
merged 3 commits into from Jul 3, 2019

Conversation

@uilianries
Copy link
Member

@uilianries uilianries commented Jul 3, 2019

Print warning message when no_proxy is in conan.conf

As you can see, I needed to pass output handler to ConanRequester. I'm not sure if it's the best choice.

Changelog: Feature: Better UX for no_proxy (#3943)
Docs: conan-io/docs#1347
closes #3943

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded
Copy link
Member

@memsharded memsharded commented Jul 3, 2019

Maybe using the warnings module, as it has been done in some other places in the codebase:

if cppstd:
        warnings.warn("Setting 'cppstd' is deprecated in favor of 'compiler.cppstd'")

The truth is that I do not like very much this mixture of conan own output and the python warnings, but once they have been introduced and as it looks it will be cleaned up in Conan 2.0, maybe that is the way to introduce it with minimal changes.

uilianries added 2 commits Jul 3, 2019
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

@uilianries uilianries commented Jul 3, 2019

Done, I made a new patch using warnings.

@memsharded memsharded merged commit 5a03f47 into conan-io:develop Jul 3, 2019
2 checks passed
@memsharded memsharded added this to the 1.17 milestone Jul 3, 2019
@memsharded
Copy link
Member

@memsharded memsharded commented Jul 3, 2019

Sure, @uilianries go ahead and add a note in the docs for this deprecation (if no_proxy is there)

@uilianries
Copy link
Member Author

@uilianries uilianries commented Jul 3, 2019

Nice, the Docs PR is ready: conan-io/docs#1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants