Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engineering] SCM discard empty string values #5459

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@danimtb
Copy link
Member

commented Jul 8, 2019

Changelog: Fix: Discard empty string values in SCM including subfolder
Docs: omit

@tags: SVN

Related to #5441
Discard the empty string values in the representation of the SCMData class.

  • Refer to the issue that supports this Pull Request: #5441 (comment)
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@lasote lasote added this to the 1.18 milestone Jul 8, 2019

@danimtb danimtb force-pushed the danimtb:feature/5402b branch from 4f18225 to 073c7e4 Jul 8, 2019

@memsharded memsharded merged commit f6b3e34 into conan-io:develop Jul 25, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.