Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Generator for python environment #5511

Merged
merged 14 commits into from Sep 14, 2019

Conversation

@birgerbr
Copy link
Contributor

@birgerbr birgerbr commented Jul 18, 2019

Changelog: Feature: Virtual environment generator for gathering only the PYTHONPATH.
Docs: conan-io/docs#1369

This pull-request closes #5157

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@lasote lasote added this to the 1.18 milestone Jul 26, 2019
Copy link
Contributor

@lasote lasote left a comment

We would need some tests. We can help with that, just tell us.


def _python_paths(deps_env_info):
result = set()
for dep in deps_env_info.deps:
Copy link
Contributor

@lasote lasote Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should access directly to the aggregated value of deps_env_info.get("PYTHONPATH"). Have you tried? (note: I don't remember if that works)

Copy link
Contributor Author

@birgerbr birgerbr Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.deps_env_info.vars.get("PYTHONPATH", []) works.

@lasote lasote removed this from the 1.18 milestone Jul 29, 2019
@lasote lasote added this to the 1.19 milestone Jul 29, 2019
@birgerbr birgerbr force-pushed the virtualenv_python branch from 41e4922 to aff68b8 Aug 1, 2019
@birgerbr
Copy link
Contributor Author

@birgerbr birgerbr commented Aug 1, 2019

We would need some tests. We can help with that, just tell us.

Added a test now. The test currently only supports Linux and Windows. Not sure what the file-extension and delimiter should be on other systems. I guess that most should be handled like Linux.

@birgerbr
Copy link
Contributor Author

@birgerbr birgerbr commented Aug 15, 2019

The tests use file-extension '.sh' and delimiter ':' for other platform systems.

@birgerbr
Copy link
Contributor Author

@birgerbr birgerbr commented Aug 15, 2019

Anny comments @lasote ?

@lasote
Copy link
Contributor

@lasote lasote commented Sep 13, 2019

@birgerbr I opened a PR in your fork with some modifications. Sorry for the delay :(

@birgerbr
Copy link
Contributor Author

@birgerbr birgerbr commented Sep 13, 2019

@birgerbr I opened a PR in your fork with some modifications. Sorry for the delay :(

Aight ✌️ I'll check it out.

@lasote lasote self-assigned this Sep 13, 2019
lasote
lasote approved these changes Sep 13, 2019
Co-Authored-By: Luis Martinez de Bartolome Izquierdo <lasote@gmail.com>
@lasote lasote merged commit db8a8c7 into conan-io:develop Sep 14, 2019
2 checks passed
Milestone 1.19 Release automation moved this from Triaging to Done Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants