Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5378 Search custom settings #5521

Merged

Conversation

@uilianries
Copy link
Member

commented Jul 19, 2019

  • Search sub-settings for common settings

Changelog: Feature: Search custom settings (#5378)
Docs: conan-io/docs#1371
closes #5378

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#5378 Search custom settings
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries referenced this pull request Jul 19, 2019
@memsharded
Copy link
Contributor

left a comment

Looks good, thanks!

@memsharded

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

I'd say that this looks good, but I would appreciate some discussion about the issues raised here #5378 about some possible breaking behavior

@Minimonium

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2019

Aren't these not "custom settings", but an any subset of blessed ones?

@lasote lasote added this to the 1.18 milestone Jul 26, 2019

@memsharded memsharded merged commit fafd061 into conan-io:develop Jul 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
@memsharded memsharded referenced this pull request Jul 26, 2019
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.