Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clean modified command #5533



Copy link

commented Jul 25, 2019

Changelog: Fix: Remove conan graph clean-modified command, it is automatic and no longer necessary.
Docs: conan-io/docs#1378

@memsharded memsharded added this to the 1.18 milestone Jul 25, 2019


lasote approved these changes Jul 26, 2019

Copy link

left a comment

Just change a docstring.

@@ -158,19 +158,14 @@ def update_lock(self, new_lock):
and raise
for id_, node in new_lock._nodes.items():
if node.modified:
if node.modified == BINARY_BUILD:

This comment has been minimized.

Copy link

lasote Jul 26, 2019


Update the docstring of this method, it is not accurate anymore. Explain the "BINARY_BUILD" that after the merge is changed by "True"

@memsharded memsharded merged commit 9f3e486 into conan-io:develop Jul 26, 2019

1 check passed

license/cla Contributor License Agreement is signed.

@memsharded memsharded deleted the memsharded:feature/remove_clean_modified_command branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.