Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clean modified command #5533

Merged

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Jul 25, 2019

Changelog: Fix: Remove conan graph clean-modified command, it is automatic and no longer necessary.
Docs: conan-io/docs#1378

lasote
lasote approved these changes Jul 26, 2019
Copy link
Contributor

@lasote lasote left a comment

👍
Just change a docstring.

@@ -158,19 +158,14 @@ def update_lock(self, new_lock):
and raise
"""
for id_, node in new_lock._nodes.items():
if node.modified:
if node.modified == BINARY_BUILD:
Copy link
Contributor

@lasote lasote Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the docstring of this method, it is not accurate anymore. Explain the "BINARY_BUILD" that after the merge is changed by "True"

@memsharded memsharded merged commit 9f3e486 into conan-io:develop Jul 26, 2019
1 check passed
@memsharded memsharded deleted the feature/remove_clean_modified_command branch Jul 26, 2019
theodelrieu added a commit to theodelrieu/conan that referenced this issue Feb 4, 2020
theodelrieu added a commit to theodelrieu/conan that referenced this issue Feb 4, 2020
theodelrieu added a commit to theodelrieu/conan that referenced this issue Feb 11, 2020
theodelrieu added a commit to theodelrieu/conan that referenced this issue Feb 17, 2020
memsharded added a commit that referenced this issue Feb 18, 2020
* Revert "remove clean modified command (#5533)"

This reverts commit 9f3e486.

* pass revisions_enabled to GraphLockFile.load

* fixing tests

* better check for clean-modified

Co-authored-by: James <james@conan.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants